AT2.01.01 & AT2.04.01 Updated#195
Conversation
SacciadisG
requested review from
CanadianMaple-Syrup,
DallaliRim,
SaraH6734,
Strange4,
YehJordan and
benjaminsunliu
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Adds new Maestro acceptance test flows for Epic 2 to validate (1) selecting start/destination buildings and (2) switching between transportation modes when viewing directions, aligning with the app’s directions UI (selectors + route list).
Changes:
- Added a Maestro flow for selecting start + destination buildings in the directions panel.
- Added a Maestro flow for switching transportation modes (walking/transit/driving/bicycling) and selecting a route.
- Introduced a short “wait for animation” step after opening the Expo link in both new flows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| maestro/US2/AT1selectStartDestinationBuilding.yaml | New Maestro flow covering start/destination selection (currently includes extra clear/reset behavior). |
| maestro/US2/AT4chooseBetweenTransportationModes.yaml | New Maestro flow covering mode switching and route selection (uses coordinate-based swipe to expand routes). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…Link for US2 AT1 and AT4.
SaraH6734
left a comment
SaraH6734
left a comment
There was a problem hiding this comment.
Looks great! just a couple minor changes
…anges. Added both tests to automated suite.
Vinuyans
left a comment
Vinuyans
left a comment
There was a problem hiding this comment.
Ran the tests on my end and they all passed. Great tests with clear comments explaining the steps. Good work
benjaminsunliu
left a comment
benjaminsunliu
left a comment
There was a problem hiding this comment.
Workflow fails on your branch: https://github.com/benjaminsunliu/ConUMap/actions/runs/24006398218/job/70010714330
Check test logs & mp4 recording and fix.
|
Summary
Added ATs 2.1 & 2.4 for epic 2, with minor tweaks to the output.
Videos below.
Related Issues
#91
#94
Testing
Checklist (Author & Reviewer)
US2_AT1.mp4
US2_AT4.mp4