AT4.02.01 User can view the shortest route to a room on the same floor

[SaraH6734]

Summary

added AT4.02.01

Related Issues

Closes: TSK#152 #issue

Changes Made

• added AT 4.02.01 User can view the shortest route to a room on the same floor

Testing

• Manual testing performed (describe briefly)
• Unit tests added or updated (if applicable)
• All tests pass locally / in CI

Checklist (Author & Reviewer)

• Code follows project conventions
• The change was run locally and works as expected
• Acceptance criteria met
• No breaking changes

[Copilot]

Pull request overview

Adds an automated Maestro acceptance flow for US4 (shortest indoor route on the same floor) and exposes navigation path segments with testIDs so the E2E flow can assert that a route is rendered.

Changes:

• Add testID to rendered indoor navigation <Line> segments in the floor SVG overlay.
• Add a new Maestro flow that selects rooms on VL floor 2 and asserts a navigation segment becomes visible.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
components/map/building-floor.tsx	Adds a testID to each rendered navigation path line segment for E2E discoverability.
.maestro/US4/AT2shortestRouteToRoom.yaml	New Maestro flow that navigates to the indoor map, selects start/end rooms, and asserts a route segment is drawn.

Comments suppressed due to low confidence (1)

components/map/building-floor.tsx:74

• For E2E stability, consider making the navigation line testID direction-independent (e.g., canonicalize the edge by sorting the two checkpoint IDs) so the same segment has the same identifier regardless of whether the route is computed A→B or B→A. This avoids fragile tests and potential duplicate IDs if the same edge is ever rendered in reverse.

      isStepMode,
      activeStepIndex,
      navigationPathColor,
      activeStepOutlineColor,

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[SaraH6734]

AT4.02.01.-.SD.480p.mov

[SacciadisG]

Solid stuff. Seems to work fine on my end, as well.
Arguably, maybe choose rooms further apart for better testing. This feels a bit short.
Nonetheless, approving - choosing diff rooms is up to you.

[SacciadisG]

Good call. We'll focus on having the CI pass in due time, we'll just focus on having the E2Es on master & work from there.

[SacciadisG]

On 2nd thought, before merging this, can we try again to get it to pass?
Try the following:

• Make sure u run the workflow on ur branch to make sure it works
• This can be done through the actions page => select the Maestro E2E IOS workflow and run manually, then select ur branch
  ** If it fails check the logs or recording to fix it, u can download them when the workflow ends

[SacciadisG]

New Plan:
Prioritize shipping; if this is taking too long, we can leave for the week. Approving conditionally - ensure CI passes.
If not, remove this & ping me again to re-approve. Cheers.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[SacciadisG]

Works on my end. Nice flow. Kudos.