[REFACTORING] Indoor Poi Marker Factory

[CanadianMaple-Syrup]

Summary

Attempts to replace the current marker rendering with a simple factory method implementation

Took inspiration from a mix of textbook factory method and this article

Related Issues

Closes: N/A

Changes Made

• Reorganized some component files to separate outdoor map components from indoor ones
• Separated the indoor POI markers component from the indoor map
• Created a factory for indoor markers for extensibility and maintainability purposes

Testing

• Manual testing performed (Ran the application on my emulator to ensure that it still worked the same and that I didn't break any features)
• Unit tests added or updated (if applicable)
• All tests pass locally / in CI

Checklist (Author & Reviewer)

• Code follows project conventions
• The change was run locally and works as expected
• Acceptance criteria met
• No breaking changes

[codecov]

Codecov Report

❌ Patch coverage is 94.73684% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
components/map/indoor-map/building-floor.tsx	92.15%	4 Missing ⚠️

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

Refactors the indoor map UI by moving indoor-specific components under components/map/indoor-map/ and introducing a factory-based approach for rendering indoor POI markers to make marker rendering more extensible.

Changes:

• Added a PoiFilters type to centralize indoor POI filter state typing.
• Split indoor map UI into dedicated components (room fields, settings, navigation controls, floor selection).
• Replaced inline POI marker rendering with a DefaultMarkerFactory + DefaultPoiMarker implementation.

Reviewed changes

Copilot reviewed 11 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
types/mapTypes.ts	Adds shared PoiFilters type for indoor POI filtering.
components/map/indoor-map/indoor-room-fields.tsx	New indoor route start/end room inputs with suggestion UI.
components/map/indoor-map/indoor-poi/default-poi-marker.tsx	Extracted reusable SVG marker (icon + optional highlight).
components/map/indoor-map/indoor-poi/default-marker-factory.tsx	Introduces factory to create POI markers by checkpoint type/metadata.
components/map/indoor-map/indoor-navigation-controls.tsx	New component for step/floor navigation controls UI.
components/map/indoor-map/indoor-map-settings.tsx	New settings UI for wheelchair routing + POI highlighting toggles.
components/map/indoor-map/floor-selection-menu.tsx	New dropdown UI for selecting the active floor.
components/map/indoor-map/building-floor.tsx	Indoor floor renderer updated to use the marker factory.
components/map/building-floor.tsx	Removes old indoor floor renderer implementation from the prior location.
app/(tabs)/(map)/[buildingCode].tsx	Updates imports to new indoor-map component locations.
__tests__/*	Updates import/mocking paths to match the new component locations.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[YehJordan]

I think this is a good refactoring, and it is a good improvement from the previous code. However, I don't think we can call this a textbook Gang of Four factory design pattern since there are no usage of subclasses to decide the POI.

But the way I see it, its more like a typescript version of a factory pattern.

All previous functionalities work like before, and the indoor POI marker features look like they function the same as well. Good work 👍

[CanadianMaple-Syrup]

I think this is a good refactoring, and it is a good improvement from the previous code. However, I don't think we can call this a textbook Gang of Four factory design pattern since there are no usage of subclasses to decide the POI.

But the way I see it, its more like a typescript version of a factory pattern.

Yeah I agree it isn't quite the textbook version of it because every component is a "subclass" of the ReactElement so we can't quite use the subclassing aspect of the "product" side of things, but we do have a generic factory type, so its like having half of the textbook I guess?

[Strange4]

Looks exactly like when we discussed in the thread. I think that this is a good improvement.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.9% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarQube Cloud