Skip to content

Fix last sonar #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Strange4 merged 5 commits into from
Apr 6, 2026
Merged

Fix last sonar #219

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c88b19
[REFACTOR] - switch negated if statement
Strange4 Apr 6, 2026
0725653
[REFACTOR] - remove duplicated props
Strange4 Apr 6, 2026
874d0d7
[REFACTOR] - replace nested conditional with guard clause
Strange4 Apr 6, 2026
cc65c54
add back console log
Strange4 Apr 6, 2026
0554b9a
Merge branch 'master' into fix-last-sonar
Strange4 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions utils/directions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,14 +518,13 @@ async function handleShuttleRouting(
}
// if directTransit route is available, do early check to save time

if (directTransit !== null) {
if (
preShuttlePath.totalDurationSeconds + shuttleTransitTime >=
if (
directTransit !== null &&
preShuttlePath.totalDurationSeconds + shuttleTransitTime >=
directTransit.totalDurationSeconds
) {
console.log("direct transit route is faster than pre + shuttle");
return [];
}
) {
console.log("direct transit route is faster than pre + shuttle");
return [];
} else {
console.log("no direct transit route");
}
Expand Down
Loading