Skip to content

Added AT4.3#220

Merged
SacciadisG merged 8 commits into
masterfrom
148-at43
Apr 6, 2026
Merged

Added AT4.3#220
SacciadisG merged 8 commits into
masterfrom
148-at43

Conversation

@SacciadisG
Copy link
Copy Markdown
Collaborator

Summary

Added AT4.3 & modified testId for settingsButton indoors, in line with other existing PRs.

Related Issues

#148
#159

Testing

  • Manual testing performed (describe briefly)
  • Unit tests added or updated (if applicable)
  • All tests pass locally / in CI

Checklist (Author & Reviewer)

  • Code follows project conventions
  • The change was run locally and works as expected
  • Acceptance criteria met
  • No breaking changes
US4-AT3.mp4

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR supports the indoor accessibility routing E2E work by adding stable UI selectors for the indoor settings controls and introducing a Maestro flow that exercises the “wheelchair accessible” path flow in US4.

Changes:

  • Added a testID to the indoor settings button and the wheelchair accessibility Switch.
  • Added a Maestro flow (US4/AT3viewAccessibilityPath.yaml) to enable accessibility mode and create an indoor route.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
components/map/indoor-map-settings.tsx Adds testIDs used by Maestro to locate the indoor settings button and accessibility toggle.
.maestro/US4/AT3viewAccessibilityPath.yaml New Maestro acceptance flow to toggle wheelchair mode and generate an indoor route.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread components/map/indoor-map-settings.tsx
Comment thread .maestro/US4/AT3viewAccessibilityPath.yaml
Comment thread .maestro/US4/AT3viewAccessibilityPath.yaml
Comment thread .maestro/US4/AT3viewAccessibilityPath.yaml
Copy link
Copy Markdown
Collaborator

@SaraH6734 SaraH6734 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just one issue

Comment thread .maestro/US4/AT3viewAccessibilityPath.yaml Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 6, 2026

@SacciadisG SacciadisG requested a review from SaraH6734 April 6, 2026 02:40
Copy link
Copy Markdown
Collaborator

@SaraH6734 SaraH6734 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The tests work well

@SacciadisG SacciadisG merged commit 78b202c into master Apr 6, 2026
4 checks passed
@SacciadisG SacciadisG deleted the 148-at43 branch April 6, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants