Skip to content

52 tsk10403 display building info#78

Merged
DallaliRim merged 40 commits into
masterfrom
52-tsk10403-display-building-info-pop-up
Feb 6, 2026
Merged

52 tsk10403 display building info#78
DallaliRim merged 40 commits into
masterfrom
52-tsk10403-display-building-info-pop-up

Conversation

@DallaliRim

@DallaliRim DallaliRim commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

Created a Building Info Popup that displays the relevant building information (Building name, building code, address, website link, opening hours, and accessibility. Added interactive building markers to the map with clustering support to reduce clutter and improve usability at different zoom levels. Each building is now represented by a clickable marker displaying its building code, with visual feedback for selection. When zoomed out, nearby buildings are grouped into cluster markers that display the number of buildings contained, reducing visual clutter. Additionally, updated the app color scheme and header logo to better align with the UI design and improve visual consistency across light and dark modes.

Related Issues

Closes:

Changes Made

  • Created a Building Info Card layout
  • Added clickable building markers displaying building codes
  • Implemented marker clustering with custom cluster markers showing building counts (e.g. 9+)
  • Highlighted the selected building marker via color inversion
  • Synced marker and polygon selection to open the Building Info Card
  • Improved map usability by reducing marker clutter at low zoom levels
  • Updated app color scheme for improved visual consistency
  • Added theme-aware header logo to match light and dark modes

Testing

  • Manual testing performed (verified marker & polygon selection, clustering behavior, zoom interactions, and Building Info Card display)
  • Unit tests added or updated (if applicable)
  • All tests pass locally / in CI

Checklist (Author & Reviewer)

  • Code follows project conventions
  • The change was run locally and works as expected
  • Acceptance criteria met
  • No breaking changes

@DallaliRim DallaliRim linked an issue Feb 3, 2026 that may be closed by this pull request
@DallaliRim DallaliRim marked this pull request as ready for review February 4, 2026 15:28
@DallaliRim DallaliRim requested a review from YehJordan February 4, 2026 15:28
Comment thread components/map/map-viewer.tsx Outdated
@DallaliRim DallaliRim changed the title 52 tsk10403 display building info pop up 52 tsk10403 display building info Feb 4, 2026

@CanadianMaple-Syrup CanadianMaple-Syrup left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall pretty good, but there are a few minor changes that need to be made.

The CL building has an incorrect marker placement.

The GS building either has an incorrect marker or an incorrect polygon (both buildings have the same address on google maps)

Comment thread app/(tabs)/_layout.tsx Outdated
Comment thread app/(tabs)/_layout.tsx Outdated
Comment thread components/map/map-viewer.tsx Outdated
Comment thread components/map/map-viewer.tsx Outdated
Comment thread components/map/map-viewer.tsx Outdated
Comment thread components/map/building-info-popup.tsx Outdated
Comment thread components/map/building-info-popup.tsx
@codecov

codecov Bot commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread components/map/map-viewer.tsx Outdated
@sonarqubecloud

sonarqubecloud Bot commented Feb 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@DallaliRim

Copy link
Copy Markdown
Collaborator Author

Finally looks good guys! Thanks for the help 🥹

@CanadianMaple-Syrup CanadianMaple-Syrup left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes that I requested have been made. Will need other people's approval first since I also coded in this branch

@YehJordan YehJordan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks good now :) Other than the cluster bug for IOS (To solve later), everything from the logo to the clickable building info pop ups work very well (For IOS). Good work 👍

@CanadianMaple-Syrup

Copy link
Copy Markdown
Collaborator

Quality Gate Failed Quality Gate failed

Failed conditions 1 Security Hotspot 0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

The failed security hotspot isn't an issue since it is parsing static data

@JenLys JenLys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good
All stylistic elements have been followed: correct colour codes, proper logo sizing, good overlays, and information pop-ups work and concord with the UI mockups.
CL building marker has been fixed 👍

Re-tested on Android and although the clusters work well it seems that there is a slight little glitch once I zoom-- something I haven't noticed during my earlier tests (see screen recording below). This is minor and can be negligeable: however long-term this might be frustrating for sensory sensitive users. This cluster issue might be perhaps related to what is happening on IOS? *to see during a later sprint

Great work! :)

Screen recording of the tiny info pop-up glitch: https://drive.google.com/file/d/1tMDxK5CcZqnfs1rL3EcEAKeTnko9ehyG/view?usp=drivesdk

Image

@DallaliRim DallaliRim merged commit d484f16 into master Feb 6, 2026
3 of 4 checks passed
@DallaliRim DallaliRim deleted the 52-tsk10403-display-building-info-pop-up branch February 6, 2026 04:30
@DallaliRim DallaliRim linked an issue Feb 6, 2026 that may be closed by this pull request
@JenLys JenLys restored the 52-tsk10403-display-building-info-pop-up branch February 15, 2026 18:01
@benjaminsunliu benjaminsunliu deleted the 52-tsk10403-display-building-info-pop-up branch April 3, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

7 participants