52 tsk10403 display building info#78
Conversation
Co-authored-by: Vinuyans <92943667+Vinuyans@users.noreply.github.com>
Co-authored-by: Vinuyans <92943667+Vinuyans@users.noreply.github.com>
Co-authored-by: Vinuyans <92943667+Vinuyans@users.noreply.github.com>
CanadianMaple-Syrup
left a comment
There was a problem hiding this comment.
Overall pretty good, but there are a few minor changes that need to be made.
The CL building has an incorrect marker placement.
The GS building either has an incorrect marker or an incorrect polygon (both buildings have the same address on google maps)
…thub.com/benjaminsunliu/ConUMap into 52-tsk10403-display-building-info-pop-up
…thub.com/benjaminsunliu/ConUMap into 52-tsk10403-display-building-info-pop-up
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
|
Finally looks good guys! Thanks for the help 🥹 |
CanadianMaple-Syrup
left a comment
There was a problem hiding this comment.
All changes that I requested have been made. Will need other people's approval first since I also coded in this branch
YehJordan
left a comment
There was a problem hiding this comment.
Everything here looks good now :) Other than the cluster bug for IOS (To solve later), everything from the logo to the clickable building info pop ups work very well (For IOS). Good work 👍
The failed security hotspot isn't an issue since it is parsing static data |
JenLys
left a comment
There was a problem hiding this comment.
Implementation looks good
All stylistic elements have been followed: correct colour codes, proper logo sizing, good overlays, and information pop-ups work and concord with the UI mockups.
CL building marker has been fixed 👍
Re-tested on Android and although the clusters work well it seems that there is a slight little glitch once I zoom-- something I haven't noticed during my earlier tests (see screen recording below). This is minor and can be negligeable: however long-term this might be frustrating for sensory sensitive users. This cluster issue might be perhaps related to what is happening on IOS? *to see during a later sprint
Great work! :)
Screen recording of the tiny info pop-up glitch: https://drive.google.com/file/d/1tMDxK5CcZqnfs1rL3EcEAKeTnko9ehyG/view?usp=drivesdk



Summary
Created a Building Info Popup that displays the relevant building information (Building name, building code, address, website link, opening hours, and accessibility. Added interactive building markers to the map with clustering support to reduce clutter and improve usability at different zoom levels. Each building is now represented by a clickable marker displaying its building code, with visual feedback for selection. When zoomed out, nearby buildings are grouped into cluster markers that display the number of buildings contained, reducing visual clutter. Additionally, updated the app color scheme and header logo to better align with the UI design and improve visual consistency across light and dark modes.
Related Issues
Closes:
Changes Made
Testing
Checklist (Author & Reviewer)