Open
Conversation
Contributor
Author
|
@benjiec these are minor updates to the v2 branch to allow successful bower registration. |
- wrappers.ironReuquest takes in a Polymer `iron-request` element object and returns an appropriate `POST` request-making function - all of the wrapper functions now take an optional `options` argument to merge in object sent to the request client, for providing additional, client-specific options.
Also add tests to verify objects are constructed with camelCased keys
It messes up the server, apparently
- Expose CuriousObject as CuriousObjects.defaultType - Add CurousObject.prototype.toJSON so that JSON.stringify(curiousObject) works - Add CuriousObject.fromJSON for easy parsing from JSON strings
Not strings or Arrays
Resolve URL convention
Bind the post method of axios.
Bower only uses git tags for versioning, as described in the [spec](https://github.com/bower/spec/blob/master/json.md#version)
Line breaks were not properly being removed: global replace must use a regexp, not a plain string
Fix query cleanup
Untrimmed whitespace at the ends is also bad apparently
Remove AMD name
Fix docs and update JS dev deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
{bower,package}.jsonfiles should have a version that starts with 2 in this branch.