Skip to content

Fix hiding of outer labels #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moisseev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix hiding of outer labels #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions d3pie-source/_labels.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ var labels = {
.attr("fill", "none")
.style("opacity", function(d, i) {
var percentage = pie.options.labels.outer.hideWhenLessThanPercentage;
var isHidden = (percentage !== null && d.percentage < percentage) || pie.options.data.content[i].label === "";
var isHidden = (percentage !== null && pie.options.data.content[i].percentage < percentage) || pie.options.data.content[i].label === "";
return isHidden ? 0 : 1;
});
},
Expand Down Expand Up @@ -440,7 +440,7 @@ var labels = {

isLabelHidden: function(pie, index) {
var percentage = pie.options.labels.outer.hideWhenLessThanPercentage;
return (percentage !== null && d.percentage < percentage) || pie.options.data.content[index].label === "";
return (percentage !== null && pie.options.data.content[index].percentage < percentage) || pie.options.data.content[index].label === "";
},

// does a little math to shift a label into a new position based on the last properly placed one
Expand Down