Added new label rendering mode "aside" to render labels in two vertical stacks instead of around the circle.#161
Open
mnori wants to merge 2 commits intobenkeen:masterfrom
Open
Added new label rendering mode "aside" to render labels in two vertical stacks instead of around the circle.#161mnori wants to merge 2 commits intobenkeen:masterfrom
mnori wants to merge 2 commits intobenkeen:masterfrom
Conversation
…g the left and right flanks of the pie chart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I described an issue in #160 where clusters of small segments at the bottom of the pie cause label lines to overlap:
I couldn't work out how to fix this and keep the circular label positioning, but did end up creating a new alternative label positioning mode called "aside" where the labels are rendered as two vertically aligned lists, this gets rid of the problem:
The new rendering mode can be activated with a config option:
Demo of the bug and the new "aside" rendering mode can be found here: https://codepen.io/wildtype/pen/ajjrmr