Skip to content

Revert "Art net timecode draft" #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
norbertrostaing merged 1 commit into from
Jan 13, 2026
Merged

Revert "Art net timecode draft" #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions Source/TimeMachine/Sequence/ChataigneSequence.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,7 @@ ChataigneSequence::ChataigneSequence() :
reverseOffset = addBoolParameter("Reverse Offset", "This allows negative offset", false);
resetTimeOnMTCStopped = addBoolParameter("Reset on MTC Stop", "If checked, sequence will stop and reset time when MTC doesn't send data anymore. If not checked, sequence will just keep its current time", false);

artnetTimecodeRemoteIP = addStringParameter("Artnet TC remote","Send artnet TC to this host", "127.0.0.1",false);
artnetTimecodeRemoteIP->canBeDisabledByUser = true;

artnetFrameRate = addEnumParameter("Artnet TC framerate","Framerate of artnet tc");
artnetFrameRate->addOption("Film24", 0)->addOption("EBU25", 1)->addOption("DF2997", 2)->addOption("SMPTE30", 3);
artnetStreamId = addIntParameter("Artnet stream ID", "Stream id of timecode to send",0,0,255);

std::function<bool(ControllableContainer*)> typeCheckFunc = [](ControllableContainer* cc) { return dynamic_cast<AudioModule*>(cc) != nullptr; };
ltcModuleTarget->defaultContainerTypeCheckFunc = typeCheckFunc;
Expand Down Expand Up @@ -400,10 +395,6 @@ void ChataigneSequence::onContainerParameterChangedInternal(Parameter* p)
if (ltcModuleTarget->enabled) setLTCAudioModule((AudioModule*)ltcModuleTarget->targetContainer.get());
else setLTCAudioModule(nullptr);
}

if (p == currentTime && artnetTimecodeRemoteIP->enabled) {
sendArtnetTimecode();
}
}

void ChataigneSequence::onControllableStateChanged(Controllable* c)
Expand Down Expand Up @@ -520,44 +511,3 @@ void ChataigneSequence::mtcTimeUpdated(bool isFullFrame)
if (mtcReceiver->isPlaying && !isPlaying->boolValue() && time >= 0 && time < totalTime->floatValue()) playTrigger->trigger();
setCurrentTime(time, isJump, seekMode);
}

void ChataigneSequence::sendArtnetTimecode()
{
uint8_t p[19] = {};

const char id[8] = { 'A','r','t','-','N','e','t','\0' };
std::memcpy(p, id, 8);

// 2) OpCode = OpTimeCode = 0x9700, low byte first
p[8] = 0x00; // low
p[9] = 0x97; // high

// 3) ProtVerHi / ProtVerLo (current value 14 => 0x000e)
p[10] = 0x00; // ProtVerHi
p[11] = 0x0E; // ProtVerLo

// 4) Filler1 (0)
p[12] = 0x00;

// 5) StreamId (0 = master)
p[13] = artnetStreamId->intValue();

float time = currentTime->floatValue();
float frames = 30;
switch (artnetFrameRate->intValue()) {
case 0: frames = 24; break;
case 1: frames = 25; break;
case 2: frames = 29.9; break;
case 3: frames = 30; break;
}

// 6) Time fields
p[14] = fmodf(time, 1.0) * frames; // Frames
p[15] = int(floor(time)) % 60; // Seconds
p[16] = int(floor(time) / 60) % 60;; // Minutes
p[17] = int(floor(time) / 3600) % 24; // Hours

p[18] = artnetFrameRate->intValue();; // Type

artnetSocket.write(artnetTimecodeRemoteIP->stringValue(), 6454, p, (int)sizeof(p));
}
8 changes: 0 additions & 8 deletions Source/TimeMachine/Sequence/ChataigneSequence.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,6 @@ class ChataigneSequence :
FloatParameter* syncOffset;
BoolParameter* reverseOffset;

StringParameter* artnetTimecodeRemoteIP;
EnumParameter* artnetFrameRate;
IntParameter* artnetStreamId;
juce::DatagramSocket artnetSocket;


virtual void clearItem() override;

void setMasterAudioModule(AudioModule * module);
Expand Down Expand Up @@ -103,8 +97,6 @@ class ChataigneSequence :
virtual void mtcStopped() override;
virtual void mtcTimeUpdated(bool isFullFrame) override;

void sendArtnetTimecode();

JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(ChataigneSequence)
};

Expand Down
Loading