Add more systemd notifications #3419
Open
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I submitted a very similar patch as part of #3285 which is only slightly different:
|
pajod
reviewed
Sep 21, 2025
| [Service] | ||
| # gunicorn can let systemd know when it is ready | ||
| Type=notify | ||
| Type=notify-reload |
Contributor
Author
There was a problem hiding this comment.
Thanks for the info, I updated the PR to explain this.
Contributor
There was a problem hiding this comment.
Lines starting with # are comments in systemd. (Please keep up expecting software to be designed with common conventions in mind! That - reasonable - expectation is what keeps is from straying further into "surprise feature" territory.)
zigarn
force-pushed
the
systemd-notify-reload
branch
from
93d8eec to
3f9446f
Compare
Avoid the use of 'ExecReload' as advised in systemd.service(5)
zigarn
force-pushed
the
systemd-notify-reload
branch
from
3f9446f to
25a31e7
Compare
pajod
approved these changes
Oct 10, 2025
benoitc
requested changes
Dec 21, 2025
Owner
benoitc
left a comment
benoitc
left a comment
There was a problem hiding this comment.
please ensure systemd is only available for system that supports it.
| - Gracefully shutdown the old worker processes | ||
| """ | ||
| self.log.info("Hang up: %s", self.master_name) | ||
| systemd.sd_notify("RELOADING=1\nSTATUS=Gunicorn arbiter reloading", self.log) |
Owner
There was a problem hiding this comment.
thouis should not be part of the arbiter like this Not all systems are running systemd. Proper feature detection should be done first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type=notify-reloadand removeExecReloadin the systemd unit