asgi: get valid/invalid http tests to pass#3464
Open
pajod wants to merge 1 commit intobenoitc:masterfrom
Open
Conversation
* change asgi HTTP error exceptions to match base sync worker * use StopAsyncIteration in async def * override config in cases tests/test_asgi.py::MockConfig has non-default
Contributor
Author
|
Not resolved here (because invalid requests were never checked as thoroughly as valid ones - so its not strictly needed for those tests), but a good candidate after some refactoring: dumping a traceback inplace of logging the warning and responding
|
Owner
|
i suggest to wait for the deduplication refactoring . Coming week I will release the 25.0?0 with current state. Then what about making it for 25.1 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 101 perfectly fine HTTP test cases in
tests/requests/**.httpmany of which of no use for testing the ASGI workers right now. Let's fix that.(updated
tests/treq.pyand newtests/test_nginx.pyintentionally omitted here, they match most of my parallel PRs)