Skip to content

Fix inspect.getsourcelines() indexing bug in --spew trace hook#3495

Open
veeceey wants to merge 1 commit intobenoitc:masterfrom
veeceey:fix/spew-getsourcelines-indexing
Open

Fix inspect.getsourcelines() indexing bug in --spew trace hook#3495
veeceey wants to merge 1 commit intobenoitc:masterfrom
veeceey:fix/spew-getsourcelines-indexing

Conversation

@veeceey
Copy link

@veeceey veeceey commented Feb 10, 2026

Summary

Fixes #3344 -- crash when using --spew with code that has no __file__ in f_globals (e.g. dynamically generated code from the attrs library).

Root cause: inspect.getsourcelines() returns (lines_list, start_lineno) -- a tuple of length 2. The old code did src[lineno], which indexed the tuple itself by the frame's line number instead of indexing the source lines list. This caused:

  • AttributeError: 'int' object has no attribute 'rstrip' when lineno == 1 (because src[1] is the integer start_lineno)
  • IndexError: tuple index out of range for lineno >= 2

Fix: Properly unpack the tuple and compute the correct offset into the lines list:

# Before (buggy):
src = inspect.getsourcelines(frame)
line = src[lineno]

# After (fixed):
src_lines, src_start = inspect.getsourcelines(frame)
line = src_lines[lineno - src_start]

Also catches IndexError alongside OSError to gracefully fall back when the computed offset is out of bounds.

  • Adds a regression test that reproduces the exact crash scenario (dynamically generated code with linecache entries but no __file__ in globals, matching the attrs pattern from the bug report).

Test plan

  • New test tests/test_debug.py::TestSpew::test_getsourcelines_indexing passes
  • Verified the old code crashes with IndexError: tuple index out of range on the same test scenario
  • Verified the fix correctly retrieves source lines for dynamically generated code

🤖 Generated with Claude Code

Fix crash when using --spew with code that has no __file__ in globals
(e.g. dynamically generated code from the attrs library).

inspect.getsourcelines() returns a tuple (lines_list, start_lineno).
The old code indexed this tuple directly with the frame's line number
(src[lineno]), which caused:
- AttributeError: 'int' object has no attribute 'rstrip' when lineno=1
  (src[1] returns the integer start_lineno)
- IndexError: tuple index out of range for lineno >= 2

The fix properly unpacks the tuple and offsets into the lines list:
  src_lines[lineno - src_start]

Also catches IndexError in addition to OSError to gracefully handle
any edge cases where the offset falls outside the source lines.

Fixes benoitc#3344

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@veeceey
Copy link
Author

veeceey commented Feb 19, 2026

Friendly ping - any chance someone could take a look at this when they get a chance? Happy to make any changes if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crash with --spew

1 participant