Skip to content

Conversation

@camilajenny
Copy link

@benprew
Copy link
Owner

benprew commented Jun 29, 2025

@camilajenny can you include your test script as part of this PR? Having a test script that can be rerun later in case someone wants to change the code would be useful.

You can create the test/ directory in the root and put the files there. See geary as an example:

https://gitlab.gnome.org/GNOME/geary/-/tree/mainline

Thanks

@camilajenny
Copy link
Author

@benprew thank you for your suggestion. I added the ValaUnit to the subprojects and I created a unit test, and added the test script instructions to the unit test. It's easily extensible now, in case we need more unit tests. I did it like in geary, and ValaUnit is LGPL so we can use and modify it here without any problem. I also fixed the upgrade / downgrade flag which I broke in previous commits.

Please review again.

@benprew benprew merged commit 7404aeb into benprew:master Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants