Misc fixes and preparation for multi-platform support#10
Merged
Conversation
The Assert() added to SerializeTagToTagf() during development is incorrect since it is possible for a closed tag to be serialised when saving an actor.
These were accidentally missed during the previous round of constant conversions.
These were accidentally missed during the previous round of constant conversions.
This was accidentally missed during the previous round of constant conversions.
This was accidentally missed during the previous round of constant conversions.
This was accidentally missed during the previous round of constant conversions.
These were accidentally missed during the previous round of constant conversions.
This was accidentally missed during the previous round of constant conversions.
These were accidentally missed during the previous round of constant conversions.
These were accidentally missed during the previous round of filename conversions.
This was accidentally missed during the previous round of filename conversions.
The FTG tags are used as part of the filename extension and so must be in lower-case to ensure the correct filename is generated for case-sensitive filesystems.
The FTG tags are used as part of the filename extension and so must be in lower-case to ensure the correct filename is generated for case-sensitive filesystems.
The FTG tags are used as part of the filename extension and so must be in lower-case to ensure the correct filename is generated for case-sensitive filesystems.
The FTG tags are used as part of the filename extension and so must be in lower-case to ensure the correct filename is generated for case-sensitive filesystems.
The FTG tags are used as part of the filename extension and so must be in lower-case to ensure the correct filename is generated for case-sensitive filesystems.
The short product name is used to locate a file in the product directory and so must be in lower-case to ensure the correct filename is generated for case-sensitive filesystems.
These macros will soon need to be used outside of util.h.
The byte order of the chunk data is dependent upon the endian of the architecture as opposed to the platform.
Introduce a file containing code specific to the Windows platform, and start by moving the MUTX class to it.
At the same time remove the Mac part of the MacWin() macro since this is a Windows-only platform file.
At the same time remove the Mac part of the MacWin() macro since this is a Windows-only platform file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This series contains a number of fixes for previous PRs along with initial preparation for multi-platform support.
The fixes consist of adding several missing
KLCONST4()macros, as well as updating several filenames and FTG tags to use lower case so that files are correctly located on case-sensitive filesystems. Following this the Windows-specific platform code is split out into a separateplatwin.cppfile in preparation for adding multi-platform support.