Improve chunk source file support for cross-platform builds#9
Merged
Merged
Conversation
When attempting to build the chunk files on Linux, chomp fails unless the target container directory exists.
Since Linux uses a case-sensitive filesystem, the engine include directory must also be in lower case in order to locate the include files.
GCC fails to parse the #error directives containing apostrophes unless they are surrounded by double quotes.
…lenames This allows any include and file paths to work correctly both on Windows and non-Windows platforms.
…filenames This allows any include and file paths to work correctly both on Windows and non-Windows platforms.
…ilenames This allows any include and file paths to work correctly both on Windows and non-Windows platforms.
…names This allows any include and file paths to work correctly both on Windows and non-Windows platforms.
…lenames This allows any include and file paths to work correctly both on Windows and non-Windows platforms.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This series comes from an experimental branch to try and build 3DMMEx on other platforms and solves two main problems when attempting to build on Linux:
The most interesting part of this series is that it appears the backslashes are currently escaped incorrectly when filenames are embedded with the output chunk file, e.g.
Before:
After: