feat: new search UI #257
Draft
feat: new search UI #257
+1,463
−542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/js/components/Search/Search.tsx # src/js/features/search/query.store.ts
…/new-search-ui # Conflicts: # src/js/components/Search/Search.tsx
refact: search feature with constants, types, utils
SanjeevLakhwani
requested changes
Apr 23, 2025
| @@ -157,7 +157,7 @@ const CatalogueCard = ({ project }: { project: Project }) => { | |||
| datasets.length ? ( | |||
| <> | |||
| <Title level={5} style={{ marginTop: 0 }}> | |||
| {t('Datasets')} | |||
| {t('entities.dataset', T_PLURAL_COUNT)} | |||
There was a problem hiding this comment.
From my understanding the T_PLURAL_COUNT would produce a plural form of Dataset translated. But as T_PLURAL_COUNT is constant, it is not context dependent. Then:
- What's the difference between this and what you changed before?
- Wouldn't having it dynamic to the number of datasets make more sense?
There was a problem hiding this comment.
suggested changes in notion doc
There was a problem hiding this comment.
i want it discoverable, and pushing it below the fold imo makes it less discoverable...
There was a problem hiding this comment.
we could maybe make start with something like create a search that asks to choose b/w filters or free text?
There was a problem hiding this comment.
ideally I want the min. # clicks to get to a FTS.
|
@gsfk still WIP but soliciting feedback on this if you have some time tomorrow/friday... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
TODO: rename pane url param for search...
requires Katsu to be
edge/developbranch latest