Skip to content

feat: branding customization #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: branding customization #263

wants to merge 9 commits into from

Conversation

v-rocheleau
Copy link
Contributor

Mostly for PCGL demo, but relevant for other projects as well:

  • Enable translation of the client name in the header and document
  • Enable custom branding image height in the header
  • Enable custom site header height

davidlougheed
davidlougheed reviewed Mar 28, 2025
View reviewed changes
davidlougheed
davidlougheed requested changes Apr 2, 2025
View reviewed changes
src/js/features/metadata/metadata.store.ts
return axios
.get(projectsUrl)
.get(projectsUrl, reqConf)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is already a helper for this: authorizedRequestConfig(getState())

@v-rocheleau v-rocheleau mentioned this pull request Apr 2, 2025
Open
@davidlougheed
Copy link
Member

image

it would be good to get rid of the horizontal rule below the about text if projects cannot be loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-rocheleau @davidlougheed