feat: export all CSV matches via discovery_matches endpoint #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilenames Changed CSV export to download all matches using the discovery_matches endpoint with _format=csv parameter instead of the batch endpoints. Filenames now use i18n translations for entity names.
Removed old batch download functions (downloadIndividualCSV, downloadBiosampleCSV, downloadExperimentCSV) that are no longer used after switching to discovery_matches endpoint.
davidlougheed
requested changes
Nov 20, 2025
…xport - Use existing scopedAuthorizedRequestConfig utility instead of manually building params - Switch from fetch to axios for consistency with rest of codebase - Create useDownloadAllMatchesCSV hook to avoid passing state as parameter - Remove unused useAuthorizationHeader import
…quests - Create scopedAuthorizedRequestConfigFromParts to build config from auth + scope instead of full state - Update useDownloadAllMatchesCSV to only depend on auth and selectedScope (not entire state) - This prevents unnecessary callback recreation on unrelated Redux state changes - Improves performance by reducing re-renders
davidlougheed
requested changes
Nov 21, 2025
Without _page_size=0, the endpoint would only return the default page size instead of all matching results.
… types Since we're using the discovery_matches endpoint with _format=csv, export is automatically supported for all entity types (phenopackets, biosamples, experiments, experiment_results). No need for per-entity export configuration.
gsfk
approved these changes
Nov 21, 2025
Member
gsfk
left a comment
gsfk
left a comment
There was a problem hiding this comment.
Working as expected.
The French filenames with English-only content are a little weird, but actual content of the csv is arguably out of scope here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan