Features/beacon network unknown filters #310
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore "unknown filter" errors in the beacon network UI. This can happen if you apply a filter found in only in some nodes in the network. Currently we show an error, this pr changes this to a normal zero results response. In the future we should probably have a more general solution for using network-wide filters (perhaps have a way to highlight applicable nodes for each filter, or spend more effort making filters compatible across instances).
The usual redux error handling code is left unchanged, in case we decide we need it later (eg perhaps we could add a non-error tag to show that filters didn't apply in this case rather than completely ignoring the error).