feat: add clear button to text search #314
Open
+18
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlougheed
changed the title
davidlougheed
requested changes
Jan 15, 2026
davidlougheed
changed the title
davidlougheed
requested changes
Jan 15, 2026
| <Form.Item name="q" initialValue="" noStyle={true}> | ||
| <Input prefix={<SearchOutlined />} /> | ||
| </Form.Item> | ||
| {!!textQuery && <Button icon={<CloseOutlined />} onClick={onReset} />} |
Member
There was a problem hiding this comment.
add a disabled prop to the button to disable it when discoveryStatus === RequestStatus.Pending to visually indicate that the button should/cannot be triggered while a request is ongoing
| const onFinish = useCallback( | ||
| (values: FreeTextFormValues) => { | ||
| const query = values.q.trim(); | ||
| const navigateToTextQuery = useCallback( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a -clear- button to the search input. The button appears dynamically when a text query is present, allowing users to reset the search field updatings the URL parameters in a single click.