fix: catch error when discovery_config is not a valid JSON #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-rocheleau
requested changes
Apr 14, 2025
| try { | ||
| return rawText ? JSON.parse(rawText) : null; | ||
| } catch (e) { | ||
| // if the file is not a valid JSON |
There was a problem hiding this comment.
specifically, a console.error would be good
Comment on lines
+137
to
+139
| return { | ||
| error: `${e}`, | ||
| }; |
There was a problem hiding this comment.
If there is no parsing errors this function returns a JSON.
If we also return a JSON when there is a parsing error, the user may think that what they get here is the actual content of the file.
One thing we could do is have this hook return 2 things: the JSON content, and an error message if any occurs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catch error if config file is not a valid json preventing rendering failure