refact(explorer): use DRS object URL for download#501
Draft
davidlougheed wants to merge 1 commit intomasterfrom
Draft
refact(explorer): use DRS object URL for download#501davidlougheed wants to merge 1 commit intomasterfrom
davidlougheed wants to merge 1 commit intomasterfrom
Conversation
Member
Author
|
@noctillion we need to figure out how best to reconcile this with your changes to the DRS code. |
Contributor
I think the hybrid lookup changes in #502 are compatible with the changes here. Let me know if should I change somethig or is ready! |
noctillion
reviewed
Nov 26, 2025
| return downloadUrls[filename]?.url; | ||
| } | ||
|
|
||
| if (!uriRec?.isFetching && !uriRec?.data) { |
Contributor
There was a problem hiding this comment.
Not sure here, if the side effect here is triggered before the component is mounted, causing possible useMemo reexecution?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: create issues for the next steps of this in redmine