refact!: define a "scopeable model" base class + modelviewset scoping#536
Merged
davidlougheed merged 79 commits intodevelopfrom Jan 15, 2025
Merged
refact!: define a "scopeable model" base class + modelviewset scoping#536davidlougheed merged 79 commits intodevelopfrom
davidlougheed merged 79 commits intodevelopfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #536 +/- ##
===========================================
+ Coverage 92.04% 92.71% +0.66%
===========================================
Files 115 116 +1
Lines 4237 4391 +154
Branches 376 386 +10
===========================================
+ Hits 3900 4071 +171
+ Misses 249 229 -20
- Partials 88 91 +3 ☔ View full report in Codecov by Sentry. |
…odel-base-class # Conflicts: # chord_metadata_service/phenopackets/api_views.py
…odel-base-class # Conflicts: # chord_metadata_service/chord/tests/test_api.py # chord_metadata_service/discovery/api_views.py # chord_metadata_service/discovery/utils.py # chord_metadata_service/experiments/api_views.py # chord_metadata_service/phenopackets/api_views.py
test: add more tests / fix test issues
davidlougheed
changed the title
davidlougheed
changed the title
v-rocheleau
requested changes
Jan 15, 2025
Contributor
v-rocheleau
left a comment
v-rocheleau
left a comment
There was a problem hiding this comment.
Final requests I think, looks good!
Member
|
post-approval comment: behaviour when mismatching projects & datasets is not always consistent. If I manage to request a project_id and and an incorrect dataset_id (from another project, say), I get a mix of behaviours:
working now, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.