chore!: remove unused endpoints + FHIR + Elastic #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #553 +/- ##
===========================================
+ Coverage 90.99% 92.04% +1.05%
===========================================
Files 126 115 -11
Lines 4885 4237 -648
Branches 446 376 -70
===========================================
- Hits 4445 3900 -545
+ Misses 295 249 -46
+ Partials 145 88 -57 ☔ View full report in Codecov by Sentry. |
davidlougheed
changed the title
davidlougheed
changed the title
bump version to 10.0.0
Member
Author
|
@gsfk could you verify i'm not removing anything you use here? |
gsfk
approved these changes
Dec 6, 2024
…s-viewsets # Conflicts: # chord_metadata_service/chord/ingest/__init__.py # chord_metadata_service/chord/workflows/metadata.py
v-rocheleau
requested changes
Dec 12, 2024
Contributor
v-rocheleau
left a comment
v-rocheleau
left a comment
There was a problem hiding this comment.
Small request, will take a closer look at interpretation changes first thing tomorrow.
v-rocheleau
requested changes
Dec 13, 2024
Contributor
v-rocheleau
left a comment
v-rocheleau
left a comment
There was a problem hiding this comment.
Looks good, validated that the endpoints removed are not used elsewhere.
Few things:
- There is still the (now unused)
fhir_utils.pyfile, which links to hl7 and FHIR mapping files. restapi/schemashas an unusedFHIR_BUNDLE_SCHEMArestapi/semantic_mappings/README.mdcan probably be removed
v-rocheleau
reviewed
Dec 13, 2024
Contributor
v-rocheleau
left a comment
v-rocheleau
left a comment
There was a problem hiding this comment.
Lint fails, otherwise LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.