-
Notifications
You must be signed in to change notification settings - Fork 6
Features/alignment files indexing on ingestion json #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Features/alignment files indexing on ingestion json #574
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #574 +/- ##
========================================
Coverage 92.91% 92.91%
========================================
Files 124 124
Lines 4486 4486
Branches 391 391
========================================
Hits 4168 4168
Misses 228 228
Partials 90 90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
"~{drs_url}/ingest") | ||
echo "$resp_main" | jq -c | ||
|
||
# If it's BAM or CRAM, ingest the index as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this part of the code still isn't matching desired behaviour exactly - indices should be ingested if they're listed in the JSON; or, if no index is specified in the JSON, one should be generated (maybe in the python script using subprocess?) and put into the JSON. I think also prepare_for_drs
should extract index files as well as file paths, and this task should stay naive to the type of file it is ingesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now the best way to write this workflow might unfortunately just be as a single big Python task which uses the requests
library to ingest into DRS and, if needed, uses subprocess+samtools to generate indices for files missing the indices, rewriting the experiments JSON as it goes and then POSTing it to Katsu at the end.
Index cram and bam files if the index is not available on ingestion in the experiments_json_with_files workflow.