Skip to content

Support Packer 1.7.1 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thushjandan
Copy link

Hi,
To support packer 1.7 I have introduced following changes:

Solves #7

Could you please review my pull request?

benwebber and others added 4 commits April 28, 2019 10:29
Packer 1.4.0 introduced breaking changes to the plugin interface[1]:

  1. Builder, provisioner, and post-processor plugins now require a
     `context.Context`.
  2. Post-processor plugins also return a Boolean indicating whether the
     plugin should ignore `keep_input_artifact`.

As of writing, these changes are not documented in the plugin
documentation or release notes[2][3].

References:

  1. hashicorp/packer#7440
  2. https://github.com/hashicorp/packer/blob/4639f92f638a5186e5dcefd733dd1f77ee44de35/website/source/docs/extending/custom-post-processors.html.md
  3. https://github.com/hashicorp/packer/blob/4639f92f638a5186e5dcefd733dd1f77ee44de35/CHANGELOG.md

Fixes: benwebber#5 (benwebber#5)
@Vaelatern
Copy link

I have verified this PR works for me on 1.7.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants