update gulp version to 4.0#1475
Open
immartian wants to merge 1 commit into
Open
Conversation
Author
|
Without this change, the current code base will not be able to run, most probably showing such errors: |
|
+1, this fixed my local instance which was previously showing that 134 code you posted above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some issues including #1411 are all related to unsupported gulp v3.x, so changed the least version to v4.0.0 to assure the binding of several packages including Prism and Node-sass.
tested on both node v11.x and v12.x.