Skip to content

Conversation

@bep
Copy link
Owner

@bep bep commented Apr 7, 2025

  • xmp: Add support for additional metadata
  • xmp: Adjust type handling etc. for XMP child elements

LNA-DEV and others added 2 commits April 7, 2025 16:38
This adds support for a couple of additional metadata properties in XMP. All of these are children of the RdfDescription

XMP subject not supported #40
@LNA-DEV
Copy link

LNA-DEV commented Apr 7, 2025

I did take a look at it. Seems pretty good to me 👍


My observations

There are two issues with the tests:

  1. The mushroom.jpg.json file needs to be regenerated because you changed the file.
  2. The firstUpper function does not work correctly. The following did work for me.
func firstUpper(s string) string {
	if s == "" {
		return s
	}
	runes := []rune(s)
	runes[0] = unicode.ToUpper(runes[0])
	return string(runes)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants