Small correctness fixes - #419
Open
FastestMolasses wants to merge 2 commits into
Open
Conversation
FastestMolasses
commented
Sep 6, 2026
| var bestIndex0 = 0; | ||
| //While depth is the dominant heuristic, extremity is used as a bias to keep initial contact selection a little more consistent in near-equal cases. | ||
| var extremityScale = epsilonScale * 1e-2f; | ||
| const float extremityScale = 1e-2f; |
Contributor
Author
There was a problem hiding this comment.
This change was in reference to a similar change in the file from this commit:
9cdaaff#diff-7493f9e331a5a9f0e17ecccad6862552a08b6a55acbf485f2115ae38b679e0e2R191
Seems there were 2 cases of this in the file
FastestMolasses
commented
Sep 6, 2026
| { | ||
| Array.Resize(ref topLevelMatrix[i], newSize); | ||
| for (int j = oldSize; j < newSize; ++j) | ||
| for (int j = i < oldSize ? oldSize : 0; j < newSize; ++j) |
Contributor
Author
There was a problem hiding this comment.
Previously newly added rows get default initialized to have TaskIndex = 0 instead of TaskIndex = -1
FastestMolasses
commented
Sep 6, 2026
| rayHitHandler.OnRayHit(*ray, ref *maximumT, t, normal, 0); | ||
| } | ||
| } | ||
| break; |
Contributor
Author
There was a problem hiding this comment.
For this single threaded branch, we already compute all ray sources
FastestMolasses
commented
Sep 6, 2026
| } | ||
| } | ||
| //Regardless of why the loop stopped (capacity, node count, or a small node), everything before nodeIndex has been handled as isolated nodes. | ||
| var earlyIsolatedNodeIntervalEnd = nodeIndex; |
Contributor
Author
There was a problem hiding this comment.
earlyIsolatedNodeIntervalEnd stays at 0 if the for loop conditions terminates the loop so we move i outside the loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.