-
Notifications
You must be signed in to change notification settings - Fork 256
fix(e2e): Timestamp based forking deterministic e2e #2636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
shotes
wants to merge
223
commits into
main
Choose a base branch
from
timestamp-based-forking-dynamic-e2e
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chain/beacon-kit into timestamp-based-forking-dynamic-e2e
shotes
commented
Apr 1, 2025
| s.depositFetcher(ctx, blockNum) | ||
|
|
||
| // Store the finalized block in the KVStore. | ||
| // |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete some empty lines to appease funlen
Contributor
Author
|
Converting to draft for now in favor of the more simple immediate unlock for testing e2e with pectra: #2644. We may revisit this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the e2e tests (and anything running the
devnetchain spec) to have deterministic fork times. The timestamps for each block will ignore comet timestamps and always increase by exactlyTargetSecondsPerEth1Block.This is not the cleanest solution because we have to add special cases to the production code to support testing. However, I found that it is the most deterministic and simplest solution.
I have explored other alternatives that will not work or are far too complex:
time.Now()call happens in the cometBFT library.time.Now()by usingLD_PRELOADto loadlibfaketime, which will allow us to arbitrarily control the outcome oftime.Now()for the binary. This has the same non-deterministic fork time problem, as well as being extra complex because our containers for beacond are runningalpineinstead of any form ofdebian, making it harder to install required packages.