Skip to content

Conversation

@fridrik01
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.55%. Comparing base (76f2d4e) to head (cec67aa).

❗ There is a different number of reports uploaded between BASE (76f2d4e) and HEAD (cec67aa). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (76f2d4e) HEAD (cec67aa)
4 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2649       +/-   ##
===========================================
- Coverage   59.67%   18.55%   -41.12%     
===========================================
  Files         345        3      -342     
  Lines       15984       97    -15887     
  Branches       22       22               
===========================================
- Hits         9538       18     -9520     
+ Misses       5705       78     -5627     
+ Partials      741        1      -740     

see 342 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fridrik01 fridrik01 force-pushed the update-devnet-spec branch from ae311b4 to 14a8b5e Compare April 3, 2025 14:30
@fridrik01 fridrik01 force-pushed the update-devnet-spec branch from 14a8b5e to db5cba7 Compare April 3, 2025 14:45
@fridrik01 fridrik01 force-pushed the update-devnet-spec branch from db5cba7 to 8efc469 Compare April 3, 2025 15:05
@fridrik01 fridrik01 force-pushed the update-devnet-spec branch from b002f51 to 8efc469 Compare April 3, 2025 15:59
@fridrik01 fridrik01 force-pushed the update-devnet-spec branch from 8efc469 to 8511786 Compare April 4, 2025 10:23
@fridrik01 fridrik01 force-pushed the update-devnet-spec branch from 8511786 to bf0d2f7 Compare April 4, 2025 10:24
Copy link
Contributor

@calbera calbera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting here that eventually we probably want to remove the "devnet" spec entirely and use chain-spec by file for any custom networks (including cloud devnets, local, e2e suite, etc). Until that is fully configured (and pending my PR for UX improvements), we can continue using "devnet" spec as such

@fridrik01 fridrik01 force-pushed the update-devnet-spec branch from fd2b6b2 to 7e86f18 Compare April 10, 2025 16:02
@fridrik01 fridrik01 marked this pull request as ready for review April 10, 2025 16:03
@fridrik01 fridrik01 requested a review from a team as a code owner April 10, 2025 16:03
@fridrik01 fridrik01 force-pushed the update-devnet-spec branch from 7e86f18 to 5b56985 Compare April 22, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants