Skip to content

Conversation

@abi87
Copy link
Collaborator

@abi87 abi87 commented Jul 8, 2025

This PR allows to unlock PoL smart contracts deployment over devnet. What it does is

  • Add some contracts missing from devnet eth-genesis.json which are instead duly included in mainnet and bepolia
  • Geth needs to lower the default miner.gasprice otherwise some of the txs to deploy PoL are too small to be included in a block. Reth has no such an issue. cc @camembera
  • SetDepositStorage is modified to add operator keys to genesis. Validators public keys are reused for the time being
  • Simulated framework unit tests are modified to account for genesis validators having their operator keys already set
  • Kurtosis is modified to properly add operators keys and have them store in the genesis. Thanks @fridrik01 for unlocking this via fix(kurtosis): bypass JSON decoding error for POL operator keys by using pre-generated genesis #2863
  • One e2e test is modified to account for operator keys being added at genesis
  • deployed PoL over local devnet (via make start-devnet). The important point is to match the distributor contract in genesis.json.tmpl

@abi87 abi87 force-pushed the pol-related-eth-genesis-data branch from b88de2f to 1444470 Compare July 8, 2025 09:46
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

❌ Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.72%. Comparing base (b4a1676) to head (da3d59a).

Files with missing lines Patch % Lines
cli/commands/genesis/storage.go 83.33% 3 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2842      +/-   ##
==========================================
+ Coverage   62.63%   62.72%   +0.09%     
==========================================
  Files         353      353              
  Lines       16943    16973      +30     
==========================================
+ Hits        10612    10647      +35     
+ Misses       5480     5472       -8     
- Partials      851      854       +3     
Files with missing lines Coverage Δ
config/spec/devnet.go 100.00% <100.00%> (ø)
cli/commands/genesis/storage.go 71.94% <83.33%> (+2.21%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

--rm -v $(PWD)/${TESTAPP_FILES_DIR}:/${TESTAPP_FILES_DIR} \
-v $(PWD)/.tmp:/.tmp \
ghcr.io/berachain/bera-geth:latest \
--miner.gasprice 1 \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even setting this to 10 makes some PoL related txs fail

@abi87 abi87 self-assigned this Jul 8, 2025
@abi87 abi87 marked this pull request as ready for review July 8, 2025 11:49
@abi87 abi87 requested a review from a team as a code owner July 8, 2025 11:49
"nonce": "0x1",
"code": "0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe03601600081602082378035828234f58015156039578182fd5b8082525050506014600cf3"
},
"0xcA11bde05977b3631167028862bE2a173976CA11": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from eth-genesis.json of both mainnet and bepolia

@abi87 abi87 marked this pull request as draft July 9, 2025 07:39
Comment on lines +76 to +79
--ws \
--ws.port 8546 \
--ws.addr 0.0.0.0 \
--ws.api eth,net,txpool
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to run distributeFor bot.
Not yet the minimal configuration

@abi87 abi87 marked this pull request as ready for review August 19, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants