Skip to content

WIP: Deprecate Karalabe for fastssz (and use sszgen where possible) #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

WIP: Deprecate Karalabe for fastssz (and use sszgen where possible) #2866

wants to merge 35 commits into from

Conversation

@fridrik01
Copy link
Contributor

@fridrik01 fridrik01 commented Jul 30, 2025 •
edited
Loading

-->Do not review yet<--

TODO:

  • fix failing linters
  • Some compatibility tests are not correct and need to be updated
  • for structs with sszgen we need to explicitly run ValidateAfterDecodingSSZ as this is not generated by sszgen
  • fix failing e2e test (due to no rpc error)
  • Investigate into splitting into multiple PRs (however it is difficult to get individual PRs that compile due to dependencies between structs)
  • make sure is stable on make start-devnet
  • deploy to devnet-core and observe stability/compatibility with other validators using main branch

@fridrik01 fridrik01 self-assigned this Jul 30, 2025
@fridrik01 fridrik01 changed the title Migrate to fastssz sszgen WIP: Migrate to fastssz using sszgen where possible Jul 30, 2025
@fridrik01 fridrik01 changed the title WIP: Migrate to fastssz using sszgen where possible WIP: Deprecate Karalabe for fastssz (and use sszgen where possible) Jul 30, 2025
fridrik01 added 27 commits July 30, 2025 14:29
@fridrik01
refactor(encoding): rename ssz package to sszutil
183d816
@fridrik01
fastssz encoding + port fork
8951006
@fridrik01
migrate ForkData, SigningData and DepositMessage
f2d59bf
@fridrik01
migrate AttestionData + SlashingInfo
ce0185b
@fridrik01
Versionable needs to be a concrete struct type for sszgen
e5c2da5
@fridrik01
add fastssz support to BeaconBlockBody and UnusedType
d5dee13
@fridrik01
migrate SyncAggregate to fastssz and add B32/B96 fastssz support
bb3c7b8
@fridrik01
add fastssz support to U64, B48, and ExecutionAddress types
01a9dde
@fridrik01
prepare Deposit and Eth1Data for manual fastssz migration
ebf84e6
@fridrik01
add fastssz methods to PendingPartialWithdrawal and add more sszgen
8468e21
@fridrik01
add fastssz methods to ExecutionPayload, ExecutionPayloadHeader, and …
87237e5 
…BeaconState
@fridrik01
add fastssz support to ExecutionRequests, BeaconBlock, SignedBeaconBl…
8ca5b85 
…ockHeader, BlobSidecar and generate code for WithdrawalRequest, ConsolidationRequest
@fridrik01
add fastssz support to collection types and SignedBeaconBlock
a2c5916
@fridrik01
add UnmarshalSSZ to Deposit, Eth1Data, BeaconBlockHeader, and Validat…
3ad5c2d 
…or types
@fridrik01
(does not build) migrate core consensus types from karalabe/ssz to fa…
e6a1d3c 
…stssz
@fridrik01
migrate payload, signed block types and withdrawal from karalabe/ssz …
5cf67f6 
…to fastssz
@fridrik01
(does not build) migrate core types from karalabe/ssz to fastssz in c…
d98ce18 
…onsensus-types, engine-primitives, and primitives
@fridrik01
add nil checks for syncAggregate and BaseFeePerGas in SSZ methods, mi…
b4df61e 
…grate withdrawal/consolidation requests to fastssz
@fridrik01
complete migration from karalabe/ssz to fastssz
a3b6966
@fridrik01
remove karalabe/ssz dependency and migrate all tests to fastssz
0d1c1a4
@fridrik01
Add SSZGEN_MIGRATION_CHECKLIST.md
418ec33
@fridrik01
update HashTreeRoot interface to return error and migrate types to ss…
fdea8a3 
…zgen
@fridrik01
migrate 7 types to sszgen and add SSZ methods to KZGCommitment
15c34ac
@fridrik01
remove unused ssz md files
9ea15fd
@fridrik01
update test expectations for HashTreeRoot error handling and nil slic…
3dd9de5 
…e initialization
@fridrik01
add comprehensive SSZ compatibility tests for karalabe/ssz to fastssz…
04a70db 
… migration
@fridrik01
add SSZ compatibility tests and fix karalabe/ssz regression testing
4f9dbac
@fridrik01 fridrik01 force-pushed the migrate-to-fastssz-sszgen branch from 6bc3652 to 9d93a49 Compare July 30, 2025 15:20
@fridrik01
lint: update imports naming from fastssz to ssz to be in line with ss…
7e2a349 
…zgen

This was causing make generate-check to fail as it didn't like the imports
to be named differently
@calbera
Copy link
Contributor

calbera commented Aug 11, 2025

Maybe worth upgrading to v1.0.0 as well (#2876)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@fridrik01 fridrik01

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fridrik01 @calbera