Skip to content

Conversation

@fridrik01
Copy link
Contributor

@fridrik01 fridrik01 commented Oct 23, 2025

This PR addresses a metrics issue by removing unbounded labels from Prometheus metrics that can cause cardinality explosion and degrade system performance in our monitoring systems.

I believe it should be fine to remove these labels as we should have information about them in our logs/loki.

Note: if any Grafana dashboards relied on these labels, they may need to be updated to reflect the new metric structure.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 70.83333% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.11%. Comparing base (5fe4aab) to head (a459d97).

Files with missing lines Patch % Lines
execution/engine/metrics.go 60.00% 8 Missing ⚠️
beacon/blockchain/deposit.go 0.00% 2 Missing ⚠️
beacon/blockchain/metrics.go 85.71% 2 Missing ⚠️
beacon/blockchain/payload.go 75.00% 1 Missing ⚠️
execution/engine/engine.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           blobreactor-prometheus2    #2967      +/-   ##
===========================================================
- Coverage                    64.15%   64.11%   -0.05%     
===========================================================
  Files                          371      371              
  Lines                        18597    18591       -6     
===========================================================
- Hits                         11931    11919      -12     
- Misses                        5759     5764       +5     
- Partials                       907      908       +1     
Files with missing lines Coverage Δ
state-transition/core/metrics.go 94.80% <100.00%> (-0.07%) ⬇️
state-transition/core/state_processor_payload.go 63.86% <100.00%> (ø)
beacon/blockchain/payload.go 52.86% <75.00%> (-0.30%) ⬇️
execution/engine/engine.go 59.06% <50.00%> (ø)
beacon/blockchain/deposit.go 45.16% <0.00%> (-0.88%) ⬇️
beacon/blockchain/metrics.go 97.26% <85.71%> (ø)
execution/engine/metrics.go 67.85% <60.00%> (-0.43%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fridrik01 fridrik01 force-pushed the blobreactor-prometheus2-fix-cardinality branch from a6fbc96 to 9511120 Compare October 24, 2025 15:01
@fridrik01 fridrik01 force-pushed the blobreactor-prometheus2 branch 2 times, most recently from 784b633 to 78c4ed4 Compare October 24, 2025 16:09
@fridrik01 fridrik01 force-pushed the blobreactor-prometheus2-fix-cardinality branch from 9511120 to 08758cf Compare October 24, 2025 16:23
@fridrik01 fridrik01 force-pushed the blobreactor-prometheus2-fix-cardinality branch from 08758cf to c2d983d Compare October 24, 2025 17:54
@fridrik01 fridrik01 force-pushed the blobreactor-prometheus2-fix-cardinality branch from c2d983d to 1591a48 Compare October 27, 2025 16:01
@fridrik01 fridrik01 marked this pull request as ready for review October 27, 2025 16:13
@fridrik01 fridrik01 requested a review from a team as a code owner October 27, 2025 16:13
@fridrik01 fridrik01 force-pushed the blobreactor-prometheus2 branch from 4c886ad to 9a5c6eb Compare October 28, 2025 11:42
@fridrik01 fridrik01 force-pushed the blobreactor-prometheus2-fix-cardinality branch from 1591a48 to 232134c Compare October 28, 2025 11:49
@fridrik01 fridrik01 force-pushed the blobreactor-prometheus2 branch from 9a5c6eb to 8666900 Compare October 28, 2025 12:00
@fridrik01 fridrik01 force-pushed the blobreactor-prometheus2-fix-cardinality branch from 232134c to b9d10c6 Compare October 28, 2025 12:00
@fridrik01 fridrik01 force-pushed the blobreactor-prometheus2-fix-cardinality branch from b9d10c6 to 6051072 Compare October 28, 2025 12:09
@fridrik01 fridrik01 force-pushed the blobreactor-prometheus2-fix-cardinality branch from 6051072 to a459d97 Compare October 31, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants