Skip to content

Conversation

@qtipbera
Copy link

@qtipbera qtipbera requested review from calbera and Copilot October 17, 2025 15:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a security issue in the Multicall3 contract where blockhash(block.number) was incorrectly used, which always returns 0 according to Ethereum specifications. The fix changes it to use blockhash(block.number - 1) to get a valid previous block hash.

  • Replace incorrect blockhash(block.number) call with blockhash(block.number - 1)
  • Add explanatory comments about the blockhash behavior and safety considerations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants