-
-
Notifications
You must be signed in to change notification settings - Fork 17
Feat/wallet management #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/wallet management #237
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
|
Worth noting, I believe there is a potential bug that needs sorting. At the moment when editing setting a wallet is based on credential name and on editing account name we are only editing account name. To fix this we either list accounts ALWAYS in index order OR we set credential/account based on address/account index and not credential name, thus not inserting a new entry to the list each time edit name is done. |
|
Have fixed the potential bug pointed out in above comment with the commit 45dcc2c Ordering accounts by address index inside useEffect reorders list on account edit. Also a check in place on delete to ensure that the account to delete's address index is accounts length -1. This ensures deletion of last indexed account only. |
Describe changes
Ticket or discussion link
N/A
Review checklist
Screenshots
Account managmet screen
Editing an account
Removing an account
Can only remove the last credential in the list (to preserve account and address index count used in new account derivation)

Can not remove the initial account (at index 0).

Wallet state using new account