fix: allowedOrigin value in sandbox #239
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
|
mrcnk
approved these changes
May 2, 2025
DeMonkeyCoder
force-pushed
the
fix-sandbox-allowed-origin
branch
from
afa99b3 to
8788513
Compare
Contributor
Author
|
I realized this has security issues. Now everyone can set the allowedOrigin. The real solution is making the extension id pre-defined by using the "key" property: https://developer.chrome.com/docs/extensions/reference/manifest/key |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.