Skip to content

feat: make mina_signTransaction backward compatible #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrcnk merged 1 commit into from
Jul 1, 2025
Merged

feat: make mina_signTransaction backward compatible #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion apps/extension/src/background/handlers/web-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ import {
// StorePrivateCredentialRequestParamsSchema,
SwitchChainRequestParamsSchema,
} from "@mina-js/providers"
import {
type TransactionOrZkAppCommandProperties,
toNodeApiFormat,
} from "@mina-js/utils"
import { createMinaProvider } from "@palladco/web-provider"
import { serializeError } from "serialize-error"
import { z } from "zod"
Expand Down Expand Up @@ -176,7 +180,24 @@ export const minaSignTransaction: Handler = async ({ data }) => {
const provider = await createMinaProvider()
const payload = SignTransactionRequestParamsSchema.parse({
method: "mina_signTransaction",
params: data.params,
params: data.params.map(
(
txData:
| TransactionOrZkAppCommandProperties
| {
command: Parameters<typeof toNodeApiFormat>[0]
},
) => {
// backward compatibility with the old feePayer input schema
if ("command" in txData && "feePayer" in txData.command.feePayer) {
return {
...txData,
command: toNodeApiFormat(txData.command),
}
}
return txData
},
),
context: data.context,
})
return await provider.request(payload)
Expand Down
Loading