Populate empty -base release artifacts; clarify README IRI wording (#463)#464
Merged
Conversation
…#463) The -base release products shipped with zero METPO terms (verified empty in the 2026-05-19 release and pre-#462 main; full artifacts unaffected). Root cause: the base pipeline used `remove --base-iri $(URIBASE)/METPO --axioms external`, but METPO term IRIs are https://w3id.org/metpo/<id> (lowercase, slash), so the filter never matched and every METPO axiom was stripped. The QC report rules already use the correct $(URIBASE)/metpo. Changed line 542 to match; metpo-base.* now carries all 1454 METPO classes (imported externals still excluded). Also reworded the README IRI paragraph (Copilot review on #462) to distinguish the resolver host (w3id.org) from the canonical identifier namespace (https://w3id.org/metpo/). Pre-existing defect, not introduced by #462. Fixes #463. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the metpo-base.* build pipeline so base release artifacts retain METPO axioms (instead of being stripped due to a base-IRI prefix mismatch), and clarifies README wording about identifier namespace vs resolver host.
Changes:
- Update the ROBOT
remove --axioms externalstep for$(ONT)-base.owlto use--base-iri $(URIBASE)/metpo. - Refine README guidance to distinguish the
w3id.orghost (resolver) from the canonical METPO identifier namespacehttps://w3id.org/metpo/.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/ontology/Makefile |
Fixes the --base-iri used during base artifact generation so METPO terms are retained while external axioms are removed. |
README.md |
Clarifies identifier/IRI guidance (canonical namespace vs resolver host) and discourages OBO PURLs that do not resolve for METPO. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #463 and addresses the Copilot review comments on #462.
Empty base artifacts (#463). The
-baseproducts shipped with no METPO terms because the base pipeline filtered on--base-iri $(URIBASE)/METPO, which never matches the real term IRIshttps://w3id.org/metpo/<id>(wrong case, wrong path), soremove --axioms externalstripped everything. Changed line 542 to--base-iri $(URIBASE)/metpo(the same value the QC report rules at lines 245/248 already use). After rebuild,metpo-base.owlcarries all 1454 METPO classes (0 before); imported externals remain excluded. Pre-existing across past releases, not caused by #462.README wording (Copilot #462). Reworded to distinguish the resolver host (
w3id.org) from the canonical identifier namespace (https://w3id.org/metpo/), removing the earlier "only canonical resolution base" ambiguity.Only
metpo-base.*, the README, and the one Makefile line change;metpo.owl/metpo-full.*are untouched.Leaving open for review + Copilot before merge.