Fix ontology Makefile duplicate format entry, phony target declaration, and help-text wording#486
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Remove duplicate owl entry from FORMATS list
Fix ontology Makefile duplicate format entry, phony target declaration, and help-text wording
Jun 2, 2026
turbomam
approved these changes
Jun 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request performs small, targeted cleanups to the ODK-generated src/ontology/Makefile to reduce ambiguity in declared build formats, ensure phony target metadata matches the actual target, and correct user-facing help/echo text.
Changes:
- Removed a redundant
owltoken from theFORMATSlist (while$(sort ...)deduplicates, the explicit list is now non-redundant). - Corrected the
.PHONYdeclaration to marktest_fast(nottest) as phony in the section wheretest_fastis defined. - Fixed typos/grammar in user-facing messages and help text (
mirrorring→mirroring, and improvednormalize_srchelp wording).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies four targeted cleanups in
src/ontology/Makefileto remove ambiguity and correct target/help metadata. It eliminates a redundant format entry, fixes a phony declaration mismatch, and corrects two user-facing wording issues.Build format list cleanup
owltoken fromFORMATSto keep the declared format set explicit and non-redundant.Phony target correctness
.PHONYdeclaration adjacent totest_fastto referencetest_fast(instead of repeatingtest), so target intent matches declaration.User-facing text corrections
mirrorring→mirroring).normalize_srchelp text grammar and contraction (after editing ... it's serialised correctly).Example diff excerpt:
Original prompt