Skip to content

Fix header-check logic flow and use -eq 0 for row count in run_sparql_metatest.sh #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turbomam merged 5 commits into from
Jun 29, 2026
Merged

Fix header-check logic flow and use -eq 0 for row count in run_sparql_metatest.sh #563

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b8cb54e
Initial plan
Copilot Jun 29, 2026
bbe22e8
Fix header check logic and use -eq 0 for row count in run_sparql_meta…
Copilot Jun 29, 2026
30e9181
fix(sparql-metatest): normalize negative row count so -eq 0 works
turbomam Jun 29, 2026
4b42a8a
Merge branch 'main' into copilot/fix-header-check-logic
turbomam Jun 29, 2026
af9b0dd
Merge branch 'main' into copilot/fix-header-check-logic
turbomam Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions tests/sparql_qc/run_sparql_metatest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,23 +77,24 @@ robot query --input "$FIXTURE" --query "$HEADER_Q" "$OUT/header-fixture.tsv"
hrows=$(($(wc -l < "$OUT/header-fixture.tsv") - 1))
if [ "$hrows" -ge 1 ]; then
echo "OK ontology-header-check.sparql matched $hrows fixture violation(s)"
else
echo "::error::ontology-header-check.sparql matched 0 rows against the fixture: the check is a silent no-op."
fail=1
fi

if [ -f "$REAL_OWL" ]; then
robot query --input "$REAL_OWL" --query "$HEADER_Q" "$OUT/header-real.tsv"
rrows=$(($(wc -l < "$OUT/header-real.tsv") - 1))
if [ "$rrows" -le 0 ]; then
echo "OK ontology-header-check.sparql found no problems in metpo.owl"
if [ -f "$REAL_OWL" ]; then
robot query --input "$REAL_OWL" --query "$HEADER_Q" "$OUT/header-real.tsv"
rrows=$(($(wc -l < "$OUT/header-real.tsv") - 1))
if [ "$rrows" -eq 0 ]; then
echo "OK ontology-header-check.sparql found no problems in metpo.owl"
else
echo "::error::the ontology header in metpo.owl has $rrows metadata problem(s):"
cat "$OUT/header-real.tsv"
fail=1
fi
else
echo "::error::the ontology header in metpo.owl has $rrows metadata problem(s):"
cat "$OUT/header-real.tsv"
echo "::error::expected released ontology at $REAL_OWL but it is missing."
fail=1
fi
else
echo "::error::expected released ontology at $REAL_OWL but it is missing."
echo "::error::ontology-header-check.sparql matched 0 rows against the fixture: the check is a silent no-op."
echo "Skipping check against metpo.owl because the fixture proof-of-failure did not pass."
fail=1
fi

Expand Down
Loading