Remove code for old Django and Python versions #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace all `super(ClassName, self).method_name(...)` with `super().method_name(...)` - Updated 30 `super()` calls across 14 files - Maintains compatibility with current Django and Python versions - No functional changes, only syntax modernization
- Remove `try/except ImportError` for `django.apps` (Django 4.2+ has this) - Remove `try/except ImportError` for `django.db.models.indexes.Index` (Django 4.2+ has this) - Remove `try/except ImportError` for `StringIO` (Python 3.8+ uses `io.StringIO`) - Remove `allow_syncdb` method (Django 4.2+ only uses `allow_migrate`) - Remove Django < 1.7 model compatibility code in router - Update comments referencing old Django versions - Remove `from __future__` imports (not needed in Python 3.8+)
- Update test comment from 'Django 1.7+' to just 'Django' (no longer version-specific) - Update documentation links from Django 1.8/1.11 to Django 4.2 - Remove version-specific language that implied these were new features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modernize the codebase by removing compatibility code for old Django and Python versions, targeting Django 4.2+ and Python 3.8+ as per the project's compatibility guarantees.
Changes Made
Python 2.7 Style
super()Calls → Modern Python 3+super()calls modernized across 14 filessuper(ClassName, self).method_name(...)→super().method_name(...)Removed Defensive Imports for Old Versions
try/except ImportErrorfordjango.apps(always available in Django 4.2+)try/except ImportErrorfordjango.db.models.indexes.Index(always available in Django 4.2+)try/except ImportErrorforStringIO(Python 3.8+ always usesio.StringIO)allow_syncdbmethod (Django 4.2+ only usesallow_migrate)from __future__imports (not needed in Python 3.8+)Documentation and Comment Updates
What Was Preserved
Test Plan
The codebase is now fully modernized for the current Django LTS (4.2+) and Python 3.8+ target versions while maintaining all existing functionality.