Added support for FIFO flatfile driver #386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephane-de
reviewed
Oct 15, 2018
|
|
||
| natsort($files); | ||
| $files = array_reverse($files); | ||
| if ($this->queueType === 'life') { |
There was a problem hiding this comment.
yep, not sure why all tests pass with it :(
There was a problem hiding this comment.
Because there is no specific test for the new fifo/lifo functionality?
(i created a pull request with fix and tests against your branch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a third constructor param to FlatFileDriver:
There is one option supported:
When queue type is FIFO, the behaviour of
popMessageandpeekQueueis modified.See
\Tests\Driver\FlatFile\FifoDriverTest.phpfor tests running with FIFO config.