Fix PHP 8.1 deprecation notices #428
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi guys, |
|
@sagikazarmark any way the community can help with this? |
|
@sagikazarmark ping? can you give any update on the status of the project? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the deprecation notices reported in #425 by specifying the
intreturn type for thecountfunctions.Initially I wanted to use the
masterbranch but it is lacking the Predis driver that we use.I figured this would be more inclusive than using
#[\ReturnTypeWillChange]given we only need to bump to PHP7 or higher and not PHP8.Since this removes support for PHP5 (about time I guess? :)) I would suggest to release this as 0.14.0.