Skip to content

CMake polishing #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hextriclosan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CMake polishing #14

hextriclosan wants to merge 1 commit into from

Conversation

@hextriclosan
Copy link

@hextriclosan hextriclosan commented Aug 22, 2022

CMake polishing

added:

  • the modern approach to specifying c++ standard
  • simple finder for Portable C Audio Library
  • pthreads finder

@berthubert
Copy link
Owner

berthubert commented Aug 23, 2022

I don't have a CMake this new on some of my systems, sure you need 3.18?

@hextriclosan
Copy link
Author

hextriclosan commented Aug 23, 2022

I don't have a CMake this new on some of my systems, sure you need 3.18?

3.18 is for REQUIRED in find_library. However, I can edit the code to get back to 3.1

@hextriclosan
Copy link
Author

hextriclosan commented Aug 23, 2022

got back to 3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hextriclosan @berthubert