Skip to content

More parameters to startDownload methods #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sajid-verveba wants to merge 1 commit into
base: master
Choose a base branch
from
Open

More parameters to startDownload methods #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jspeedtest/src/main/java/fr/bmartel/speedtest/SpeedTestConst.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,12 @@ public class SpeedTestConst {
/**
* default username for FTP download/upload.
*/
public static final String FTP_DEFAULT_USER = "anonymous";
public static String FTP_DEFAULT_USER = "anonymous";

/**
* default password for FTP download/upload.
*/
public static final String FTP_DEFAULT_PASSWORD = "";
public static String FTP_DEFAULT_PASSWORD = "";

/**
* Chunk to write at each iteration for upload file generation.
Expand Down
18 changes: 18 additions & 0 deletions jspeedtest/src/main/java/fr/bmartel/speedtest/SpeedTestSocket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,24 @@ public void startDownload(final String uri) {
mTask.startDownloadRequest(uri);
}

/**
* Start download process.
*
* @param uri uri to fetch to download file
* @param username username
* @param password password
* @param maxDuration max duration for download
* @param reportInterval report time interval
*/
@Override
public void startDownload(final String uri, final String username, final String password, final int maxDuration, final int reportInterval) {
initReportTask(reportInterval);
mTask.setReportInterval(true);
SpeedTestConst.FTP_DEFAULT_USER = username;
SpeedTestConst.FTP_DEFAULT_PASSWORD = password;
startFixedDownload(uri, maxDuration);
}

/**
* Set proxy server for all DL/UL tasks.
*
Expand Down
10 changes: 10 additions & 0 deletions jspeedtest/src/main/java/fr/bmartel/speedtest/inter/ISpeedTestSocket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,16 @@ public interface ISpeedTestSocket {
*/
void startDownload(String uri);

/**
* Start download process.
*
* @param uri uri to fetch to download file
* @param username username of ftp
* @param password password of ftp
* @param maxDuration maxDuration for download file
* @param reportInterval report Interval
*/
void startDownload(final String uri,String username,String password,int maxDuration,int reportInterval);

/**
* Add a speed test listener to list.
Expand Down