Added to the API #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
July 3, 2012 20:23
Previously, if you passed in n estimators it would merge n[0] with itself n-1 times.
Tests still pass on 1.8
Conflicts: ext/hyperloglog.cpp spec/hyperloglog_spec.rb
Conflicts: spec/hyperloglog_spec.rb
You could do HyperEstimator.estimate(*estimators) but that will blow the stack on long lists.
I want to pull a bunch of estimators out of the database, merge them and cache the result
My primary use case is stuffing these into memcache
There was a problem hiding this comment.
se variable isn't even used, is it?
Contributor
Author
There was a problem hiding this comment.
No, that looks like a leftover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to merge together estimators and stick the result in memcache. Needed the following methods to do that:
HyperEstimator#merge!
HyperEstimator#_dump
HyperEstimator.load
I also changed HyperEstimator.estimate to take an array of estimators as well as a list