Skip to content

docs: Adding extra charts and customisations to Plotly cookbook.#150

Merged
rodriguesfred merged 6 commits into
devfrom
fr/hist_plotly
Mar 13, 2026
Merged

docs: Adding extra charts and customisations to Plotly cookbook.#150
rodriguesfred merged 6 commits into
devfrom
fr/hist_plotly

Conversation

@rodriguesfred

@rodriguesfred rodriguesfred commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

Adding extra charts and customisations to Plotly cookbook.
Edited plotly and matplotlib cookbooks to better align with each other.

Description

Summary

Adding histogram Plotly cookbook.
Adding customisations to Plotly cookbook.

Changes Made

Edited plotly and matplotlib cookbooks to better align with each other.

Related Issues

Edited plotly and matplotlib cookbooks to better align with each other.
@rodriguesfred

Copy link
Copy Markdown
Collaborator Author

tagging @mylsklaark to review the matplotlib edits

@nickhenden

nickhenden commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

@rodriguesfred Why are there so many changes to the matplotlib cookbook in this PR? Have you got Black or some other formatter running? I'm not a fan of the formatting changes it's made. A lot of the code is now crammed into single lines, which makes it way harder to read in the rendered cookbook.

@rodriguesfred

Copy link
Copy Markdown
Collaborator Author

@rodriguesfred Why are there so many changes to the matplotlib cookbook in this PR? Have you got Black or some other formatter running? I'm not a fan of the formatting changes it's made. A lot of the code is now crammed into single lines, which makes it way harder to read in the rendered cookbook.

sorry did not notice that. I do have formater. Most of the changes were meant to be order only to match the plotly one exactly. so they were easier to compare.

@rodriguesfred

Copy link
Copy Markdown
Collaborator Author

@rodriguesfred Why are there so many changes to the matplotlib cookbook in this PR? Have you got Black or some other formatter running? I'm not a fan of the formatting changes it's made. A lot of the code is now crammed into single lines, which makes it way harder to read in the rendered cookbook.

I've now reverted the formater changes but kept the order changes so they match.

@nickhenden nickhenden left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @rodriguesfred :) A few minor comments.

Comment thread src/afcharts/cookbook/03-plotly-usage.qmd Outdated
Comment thread src/afcharts/cookbook/01-matplotlib-usage.qmd Outdated
Comment thread src/afcharts/cookbook/03-plotly-usage.qmd Outdated
Comment thread src/afcharts/cookbook/03-plotly-usage.qmd Outdated
Comment thread src/afcharts/cookbook/03-plotly-usage.qmd Outdated
@rodriguesfred

Copy link
Copy Markdown
Collaborator Author

@nickhenden ready for rereview

@nickhenden nickhenden left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merge away

@rodriguesfred rodriguesfred merged commit df33afb into dev Mar 13, 2026
4 checks passed
@rodriguesfred rodriguesfred deleted the fr/hist_plotly branch March 13, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants