Skip to content

docs: Fr/plotly annotations#163

Merged
rodriguesfred merged 7 commits into
devfrom
fr/plotly-annotations
May 19, 2026
Merged

docs: Fr/plotly annotations#163
rodriguesfred merged 7 commits into
devfrom
fr/plotly-annotations

Conversation

@rodriguesfred
Copy link
Copy Markdown
Collaborator

@rodriguesfred rodriguesfred commented Apr 15, 2026

Adding annotation section to plotly cookbook. matching the one in Matplotlib

Related Issues
Fixes #
Closes #158
Relates to #158 #157

@nickhenden
Copy link
Copy Markdown
Collaborator

nickhenden commented May 5, 2026

@rodriguesfred I promise I haven't forgotten about your PRs! I just haven't had the time. @pbrohan would you be able to review this PR for Fred?

@rodriguesfred
Copy link
Copy Markdown
Collaborator Author

rodriguesfred commented May 5, 2026

@rodriguesfred I promise I haven't forgotten about your PRs! I just haven't had the time. @pbrohan would you be able to review this PR for Fred?
don't worry I was waiting for the sequential palette to be updated. Need to update my PRs accordingly,

@rodriguesfred
Copy link
Copy Markdown
Collaborator Author

rodriguesfred commented May 6, 2026

@rodriguesfred I promise I haven't forgotten about your PRs! I just haven't had the time. @pbrohan would you be able to review this PR for Fred?
don't worry I was waiting for the sequential palette to be updated. Need to update my PRs accordingly,

@pbrohan ready for review

@rodriguesfred
Copy link
Copy Markdown
Collaborator Author

rodriguesfred commented May 15, 2026

@nickhenden merged to dev. Ready for review.

@nickhenden nickhenden requested a review from Copilot May 18, 2026 16:29
Copilot AI reviewed May 18, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new "Annotations" section to the Plotly cookbook (mirroring the Matplotlib cookbook addition) that explains how to label charts directly and demonstrates value labels on a bar chart using go.Bar(text=...). This closes issue #158.

Changes:

  • Adds an "Annotations" section to 03-plotly-usage.qmd with prose explaining direct labelling vs legends.
  • Adds a worked example: top‑5 most populous Americas countries (2007) bar chart with value labels.
  • Adds chart title, subtitle, source, and alt-text markup for the new example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/afcharts/cookbook/03-plotly-usage.qmd Outdated
Comment thread src/afcharts/cookbook/03-plotly-usage.qmd
Comment thread src/afcharts/cookbook/03-plotly-usage.qmd
nickhenden
nickhenden reviewed May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@nickhenden nickhenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor comments from Copilot, but otherwise looks good :)

@nickhenden nickhenden linked an issue May 19, 2026 that may be closed by this pull request
Add annotations section to Plotly cookbook #158
Closed
@rodriguesfred
Copy link
Copy Markdown
Collaborator Author

rodriguesfred commented May 19, 2026

@nickhenden ready for re-review

@rodriguesfred rodriguesfred requested a review from nickhenden May 19, 2026 13:37
@rodriguesfred rodriguesfred merged commit 032586c into dev May 19, 2026
4 checks passed
@rodriguesfred rodriguesfred deleted the fr/plotly-annotations branch May 19, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@nickhenden nickhenden nickhenden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add annotations section to Plotly cookbook

3 participants

@rodriguesfred @nickhenden